-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined kTranslateUI symbol link error on windows release build #2557
Conversation
fa0b755
to
6a84c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
lint failed on mac because of PR builder bug, it's not picking up my latest lint fix change, passed on all other platforms. |
Fix undefined kTranslateUI symbol link error on windows release build
Fix undefined kTranslateUI symbol link error on windows release build
Fix undefined kTranslateUI symbol link error on windows release build
Upgrade from Chromium 71.0.3578.80 to 71.0.3578.98
Fix brave/brave-browser#4656
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.